[Bugfix] [Platform] Fix topology for Gateways

[ajanikow]

No description provided.

[Copilot]

Pull request overview

This bugfix corrects the topology affinity rules for Gateway pods in ArangoDB deployments. The PR adds topology affinity rule merging that was previously missing from Gateway pods and fixes an incorrect pod affinity configuration where Gateway pods were mistakenly configured to have affinity with DBServers instead of Coordinators.

Key changes:

• Added topology affinity rules support to Gateway pods (PodAntiAffinity, PodAffinity, and NodeAffinity)
• Corrected Gateway pod affinity from DBServers to Coordinators
• Added topology package import

Comments suppressed due to low confidence (1)

pkg/deployment/resources/pod_creator_gateway_pod.go:28

• The topology import should be grouped with other internal imports after the standard library imports and external imports. Following Go convention, imports should be ordered as: stdlib, blank line, external, blank line, internal. The topology import should be moved to line 35 (after the pod import).

import (
	"context"
	"fmt"
	"math"
	"os"

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The ordering of affinity rule merging is inconsistent with the pattern used in MemberArangoDPod.GetPodAffinity() (lines 354-356 in pod_creator_arangod.go). In ArangoDPod, GroupSpec.Affinity is merged before topology rules, but here topology rules are merged after GroupSpec.Affinity. For consistency and to ensure GroupSpec rules can override topology rules, the topology merge should happen at line 84 (before GroupSpec.Affinity).

Suggested change

	a = kresources.MergePodAffinity(a, m.GroupSpec.Affinity)
	a = kresources.MergePodAffinity(a, topology.GetTopologyAffinityRules(m.context.GetName(), m.Status, m.Group, m.Member).PodAffinity)
	a = kresources.MergePodAffinity(a, topology.GetTopologyAffinityRules(m.context.GetName(), m.Status, m.Group, m.Member).PodAffinity)
	a = kresources.MergePodAffinity(a, m.GroupSpec.Affinity)