[Bugfix] [Platform] Fix LM CLI Option #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmeuleman
approved these changes
Nov 26, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the LicenseManager CLI flag configuration where the clientSecret flag name was hardcoded instead of using the provided prefix parameter. The fix ensures consistency with all other flags in the same structure (endpoint, clientID, and stages) which properly use fmt.Sprintf to construct flag names with the prefix.
- The
clientSecretflag now correctly uses the prefix parameter to construct its name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/util/cli/lm.go | Fixed clientSecret flag name to use fmt.Sprintf with prefix parameter for consistency |
| CHANGELOG.md | Added changelog entry documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.