Skip to content

Conversation

@informalict
Copy link
Contributor

@informalict informalict commented Oct 4, 2019

No description provided.

@informalict informalict requested a review from maierlars October 4, 2019 07:06
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. (Two little suggestions)

Please add a in-cluster test. Those tests are in the /tests folder. The test should verify that changing the password secret indeed changes the password in the database.

@informalict informalict requested a review from maierlars October 7, 2019 07:32
Copy link
Contributor

@maierlars maierlars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During testing the following occurred:

  1. when the password secret is delete, the operator refuses to work. Instead nothing should happen.
  2. after the bootstrap the root password is still empty and not as expected set the one in the secret. (current upstream master works fine)

@informalict
Copy link
Contributor Author

During testing the following occurred:

  1. when the password secret is delete, the operator refuses to work. Instead nothing should happen.
  2. after the bootstrap the root password is still empty and not as expected set the one in the secret. (current upstream master works fine)

Ad 1) Fixed
Ad 2) Checked and found one issue where there was no error handling for generating random root password

@maierlars maierlars merged commit b16029b into master Oct 10, 2019
@informalict informalict deleted the feature/change-user-password branch October 10, 2019 11:12
@informalict informalict restored the feature/change-user-password branch October 17, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants