-
Notifications
You must be signed in to change notification settings - Fork 72
Feature/change user password #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
maierlars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me. (Two little suggestions)
Please add a in-cluster test. Those tests are in the /tests folder. The test should verify that changing the password secret indeed changes the password in the database.
maierlars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During testing the following occurred:
- when the password secret is delete, the operator refuses to work. Instead nothing should happen.
- after the bootstrap the root password is still empty and not as expected set the one in the secret. (current upstream master works fine)
Ad 1) Fixed |
No description provided.