Cleaning the code #501
Merged
Cleaning the code #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function CreateArangodPod has been cleaned Clean up CreateArangoSyncPod function Create interface for new containers Improvements Seperate logic into apart files Fix Nil pointer exception First unit test Add first unit test for EnsurePods function verify TLS in unit tests Add 9 unit tests for EnsurePods function Cleaning code Adjust unit test to master branch Unit test for arangosync pod Fix unit tests for sync master according to branch master Move creating volumes and volume mounts into one place Add unit test for sync worker Add unit tests for ensureImage function Add unit tests for update image add imagepullsecret and secretpullpolicy to interface Add image and env to interface Cleaning Add new unit tests Check deployment cleaning the code
informalict
force-pushed
the
refactor/cleaning-code
branch
from
6eba82d to
e1e3028
Compare
ajanikow
requested changes
Nov 25, 2019
ajanikow
approved these changes
Nov 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests:
I wrote 50 unit tests with different scenarios for
EnsurePodsandensureImagesand those tests pass on my branch and on the temporary branchtesting/after-cleaning(I created from master that only for testing because I had to export a few functions and create short helpful functions, we can assume that branch is the same like master. Compare testing branch with master: https://github.com/arangodb/kube-arangodb/compare/testing/after-cleaning)Integration tests:
Full integration tests passed with image
arangodb/enterprise-preview:3.5.3