Feature/add resources into side containers #495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maierlars
suggested changes
Nov 5, 2019
Contributor
maierlars
left a comment
maierlars
left a comment
There was a problem hiding this comment.
- what about changing requirements? Are pods rotated?
- please add tests to ensure that the resources are handed to the pods as expected (and that pods are rotated if needed)
| args []string, env map[string]EnvValue, finalizers []string, | ||
| livenessProbe *HTTPProbeConfig, readinessProbe *HTTPProbeConfig, tolerations []v1.Toleration, serviceAccountName string, | ||
| tlsKeyfileSecretName, rocksdbEncryptionSecretName string, clusterJWTSecretName string, nodeSelector map[string]string, | ||
| podPriorityClassName string, resources v1.ResourceRequirements, exporter *ArangodbExporterContainerConf, sidecars []v1.Container, vct *v1.PersistentVolumeClaim) error { |
Contributor
There was a problem hiding this comment.
I am waiting for the day that someone cleans this up.
Contributor
Author
There was a problem hiding this comment.
Test created.
Pods are rotated.
I have created a new task for cleaning up.
informalict
force-pushed
the
feature/add-resources-into-side-containers
branch
from
2a52234 to
0dfedac
Compare
informalict
force-pushed
the
feature/add-resources-into-side-containers
branch
from
0dfedac to
7707b82
Compare
Contributor
Author
|
It can not be merged because of #501. There will be a lot of conflicts and it is easier and faster to rewrite that task once again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE!!!
IBM CV requires that created pods need to have the resource requirements.
Integration test TestAddingMetrics does not work in version 3.5.2 of arangod