Skip to content

Conversation

@informalict
Copy link
Contributor

@informalict informalict commented Nov 25, 2019

IBM CV requires that created pods need to have the resource requirements.

This Pull request is rearranged from #495.
There was a lot of conflicts after cleaning the code, so it was easier to rewrite it from the begging.

  1. add new unit tests
  2. full Integration test passed with arangodb/enterprise:3.6.0 image
  3. additionally cleaning the code for metrics exporter
  4. IBM CV tool does not complain about resource requirements

Copy link
Collaborator

@ajanikow ajanikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@informalict informalict force-pushed the feature/resource-requirements-in-sidecars branch from 43b5bae to c4e30d9 Compare January 3, 2020 07:47
clean the code

Add limit resource requirements for lifecycle container

Increase hard limit for alpine container
@informalict informalict force-pushed the feature/resource-requirements-in-sidecars branch from c4e30d9 to 7b5b235 Compare January 14, 2020 11:38
@ajanikow ajanikow merged commit 523e1a3 into master Jan 16, 2020
@ajanikow ajanikow deleted the feature/resource-requirements-in-sidecars branch January 16, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants