Skip to content

Conversation

@ajanikow
Copy link
Collaborator

No description provided.

@ajanikow ajanikow requested review from ewoutp and informalict July 30, 2020 08:49
@ajanikow ajanikow force-pushed the feature/change_rotation_by_annotation_order branch from a4ff86d to 587014f Compare July 30, 2020 08:49
Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly ok, 1 suggestion


return nil
})
}, api.ServerGroupSingle, api.ServerGroupAgents, api.ServerGroupCoordinators, // Change order of execution - Coordinators and Agents should be executed before DBServer to save time
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to put this list in a global variable.

@ajanikow ajanikow merged commit 137f768 into master Jul 30, 2020
@ajanikow ajanikow deleted the feature/change_rotation_by_annotation_order branch July 30, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants