Skip to content

[Bugfix] Remove CleanOut Action #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2021
Merged

[Bugfix] Remove CleanOut Action #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f1357
Remove CleanOut Action
ajanikow Feb 19, 2021
60c8ad8
CHANGELOG
ajanikow Feb 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
- Use cached status in member client creation
- Remove failed DBServers
- Remove deadlock in internal cache
- Replace CleanOut action with ResignLeadership on rotate PVC resize mode

## [1.1.4](https://github.com/arangodb/kube-arangodb/tree/1.1.4) (2021-02-15)
- Add support for spec.ClusterDomain to be able to use FQDN in ArangoDB cluster communication
Expand Down
15 changes: 3 additions & 12 deletions pkg/deployment/reconcile/plan_builder_storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,23 +141,14 @@ func pvcResizePlan(log zerolog.Logger, group api.ServerGroup, groupSpec api.Serv
api.NewAction(api.ActionTypePVCResize, group, memberID),
}
case api.PVCResizeModeRotate:
var plan api.Plan

if group == api.ServerGroupDBServers {
plan = append(plan,
api.NewAction(api.ActionTypeCleanOutMember, group, memberID),
)
}

plan = append(plan,
return api.Plan{
api.NewAction(api.ActionTypeResignLeadership, group, memberID),
api.NewAction(api.ActionTypeRotateStartMember, group, memberID),
api.NewAction(api.ActionTypePVCResize, group, memberID),
api.NewAction(api.ActionTypePVCResized, group, memberID),
api.NewAction(api.ActionTypeRotateStopMember, group, memberID),
api.NewAction(api.ActionTypeWaitForMemberUp, group, memberID),
)

return plan
}
default:
log.Error().Str("server-group", group.AsRole()).Str("mode", mode.String()).
Msg("Requested mode is not supported")
Expand Down