Tg64/requests timeout #705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
informalict
force-pushed
the
TG64/requests-timeout
branch
11 times, most recently
from
a46756f to
682cea5
Compare
informalict
force-pushed
the
TG64/requests-timeout
branch
5 times, most recently
from
6c90c29 to
77c77ca
Compare
second draft third draft fourth draft rebase configurable timeouts pass context to cluster inspection pass context when chaning password for an user pass context during chaos tests add disclaimer make fmt calculate reconciliation timeout use context to arangosync access package secret remove CreateChildContext from resourcres apply context in GetPod pass context for deployment functions apply context when updating status of the deployment go mod tidy first my code review my second code review fix unit tests
informalict
force-pushed
the
TG64/requests-timeout
branch
from
8fb39a8 to
7e7fff3
Compare
ajanikow
requested changes
Apr 21, 2021
Collaborator
ajanikow
left a comment
ajanikow
left a comment
There was a problem hiding this comment.
Please, make ctx cancel management consistent across PR
ajanikow
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.