Skip to content

[Bugfix] Use persistent name and namespace #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2021
Merged

[Bugfix] Use persistent name and namespace #744

merged 2 commits into from
Jul 1, 2021

Conversation

@ajanikow
Copy link
Collaborator

@ajanikow ajanikow commented Jul 1, 2021 •
edited
Loading

Persist name and namespace of deployment to prevent issues when K8S API cannot be contacted

@ajanikow
Copy link
Collaborator Author

ajanikow commented Jul 1, 2021

Fixes: #743

@ajanikow ajanikow requested a review from ewoutp July 1, 2021 14:41
ewoutp
ewoutp approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@ewoutp ewoutp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajanikow ajanikow merged commit 92198ec into master Jul 1, 2021
@ajanikow ajanikow deleted the bugfix/use_persistent_name_and_namespace branch July 1, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ewoutp ewoutp ewoutp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ajanikow @ewoutp