[Cleanup] Reorganize main reconciliation context #901
Conversation
ajanikow
force-pushed
the
cleanup/reorganize_reconciliation_context
branch
from
b9bad9a to
de0c495
Compare
informalict
left a comment
informalict
left a comment
There was a problem hiding this comment.
LGTM with small comment
pkg/deployment/server_api.go
Outdated
|
|
||
| // Mode returns the mode of the deployment. | ||
| func (d *Deployment) Mode() api.DeploymentMode { | ||
| // GetAgencyClientsWithPredicate returns the mode of the deployment. |
There was a problem hiding this comment.
GetMode instead GetAgencyClientsWithPredicate
pkg/deployment/server_api.go
Outdated
|
|
||
| // Mode returns the mode of the deployment. | ||
| func (d *Deployment) Mode() api.DeploymentMode { | ||
| // GetAgencyClientsWithPredicate returns the mode of the deployment. |
There was a problem hiding this comment.
I guess there should be GetMode instead
nikita-vanyasin
left a comment
nikita-vanyasin
left a comment
There was a problem hiding this comment.
All LGTM except small comment fix for GetMode() function.
These new TODO comments in tests at 235fc6f789315bea8d9d18981b399a7c880bac8cc38421cfba0a91a818e96656R97
also does look a bit confusing but I guess this is some old code moved from one place to another?
We are not implementing not-used test functions - it is desired to do panic with them to make sure that they are not used. |
ajanikow
force-pushed
the
cleanup/reorganize_reconciliation_context
branch
from
de0c495 to
ec3c005
Compare
No description provided.