Remove Ollama/LLM text cleanup, keep deterministic cleanup#1
Merged
Conversation
Wave's cleanup had two layers: a pure-Swift DeterministicCleanup pass (disfluency removal, spoken-symbol substitution for code, identifier reassembly, spacing/casing) and an optional Ollama/LLM polish stage on top. The LLM stage required a local Ollama install that was never set up, so in practice every dictation already ran on the deterministic pass alone. This removes the entire LLM/Ollama layer and all of its UI while keeping the deterministic pass running silently — pasted output is unchanged. Removed: - OllamaClient, OllamaHealth/OllamaHealthProbe, CleanupClient, CleanupPipeline, CleanupResult, CleanupError, IdentityCache, SystemPrompt. - CleanupMode preference + the cleanupModel/ollamaURL prefs and the WAVE_CLEANUP_MODEL / WAVE_OLLAMA_URL / WAVE_CLEANUP_MODE env vars. - SkipGate.shouldSkipCleanup (LLM-skip gate) and AppPaths.identityCacheURL. - Settings -> Cleanup section (mode picker, Ollama model/URL, health probe). - History before/after "Show original" toggle and the Cleaned/Raw badge. - Onboarding "cleaned text" framing reworded to plain paste. - scripts/judge.sh, the cleanup-pairs / identifier-spelling / hallucination-audit fixtures, and the LLM-only tests. Changed: - DictationOrchestrator now calls DeterministicCleanup.transform directly. - DictationTrace / HistoryLine drop path/inputTokens/outputTokens (existing history.jsonl still decodes; extra keys are ignored). - SkipGate keeps looksLikeCodeDictation (used to route prose vs. code). - Docs/scripts updated to drop Ollama setup and the LLM gates.
…eaning-KWTXe # Conflicts: # Tests/WaveCoreTests/CleanupModeTests.swift # Tests/WaveCoreTests/CleanupPipelineTests.swift # Tests/WaveCoreTests/EndToEndIntegrationTests.swift # Tests/WaveCoreTests/FixtureGateTests.swift # Tests/WaveCoreTests/HallucinationFixtureTests.swift # Tests/WaveCoreTests/IdentityCacheTests.swift # Tests/WaveCoreTests/LatencyBudgetBenchmarkTests.swift # Tests/WaveCoreTests/OllamaHealthProbeTests.swift # Tests/WaveCoreTests/SkipGateTests.swift # Tests/WaveCoreTests/SystemPromptTests.swift # Tests/WaveCoreTests/TokenBudgetBenchmarkTests.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Wave's cleanup was actually two stacked layers:
Since Ollama was never set up, every dictation already ran on the deterministic pass alone. This PR rips out the entire LLM/Ollama layer and all of its UI surfaces, while keeping the deterministic pass running silently — so pasted output is unchanged.
Removed
OllamaClient,OllamaHealth/OllamaHealthProbe,CleanupClient,CleanupPipeline,CleanupResult,CleanupError,IdentityCache,SystemPrompt.CleanupMode,cleanupModel,ollamaURL, and theWAVE_CLEANUP_MODEL/WAVE_OLLAMA_URL/WAVE_CLEANUP_MODEenv vars.SkipGate.shouldSkipCleanup(the LLM-skip gate) andAppPaths.identityCacheURL.SkipGate.looksLikeCodeDictationis kept — it still routes prose vs. code inDeterministicCleanup.scripts/judge.sh, thecleanup-pairs/identifier-spelling/hallucination-auditfixtures, and the LLM-only tests (CleanupPipelineTests,CleanupModeTests,OllamaHealthProbeTests,SystemPromptTests,TokenBudgetBenchmarkTests,HallucinationFixtureTests,IdentityCacheTests,SkipGateTests,FixtureGateTests).Changed
DictationOrchestratorcallsDeterministicCleanup.transformdirectly (the.cleaningstatus and timing are preserved).DictationTrace/HistoryLinedroppath/inputTokens/outputTokens. Existinghistory.jsonlstill decodes —JSONDecoderignores the extra keys.Notes / judgment calls
rawTranscriptretained in the history log (now hidden in the UI) — it's invisible to users but powers theHistoryGoldenTestsreplay tool.CHANGELOG.md/TODO.mddescribing the old LLM build are left as a record, with a note pointing at the removal.Generated by Claude Code