Re-factor label-resolution. #2447
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using our standard Brunel example with cable cells instead of LIF cells we notice that
simulation setup take roughly 10x longer than the actual execution. By taking a hard look
at the label resolver functionality, we can reduce the setup time by more than half and reduce
the total runtime by half (was 15s)
Result:
Changes:
assert-univalentnorround-robin-haltactually have a state and remove those.(gid, tag).variantand associated polymorphism, replace byswitch.range_setand use linear search.