Warn when config contains bad URL#22
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds validation around custom provider URLs loaded from global git config and updates CLI error output to go to stderr.
Changes:
- Preserve deterministic provider iteration order when loading providers from git config.
- Emit a warning and skip entries when a provider URL from git config is invalid (parse fails or missing host).
- Add tests to validate default provider BaseURLs and extend provider loading tests for invalid URLs; print CLI errors to stderr.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| open/provider.go | Track provider insertion order and warn/skip invalid provider BaseURLs from git config. |
| open/provider_test.go | Add BaseURL validity test for defaults; add invalid-url case and minor parsing refactor in LoadProviders tests. |
| main.go | Route error messages to stderr instead of stdout. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
102290c to
f8bc58b
Compare
Prints a warning to stderr when a user Provider contains a malformed and non-functional URL. Adds tests for DefaultProviders. All errors and warnings are now piped to stderr over stdout.
f8bc58b to
f797565
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prints a warning to stderr when a user Provider contains a malformed and non-functional URL. Adds tests for DefaultProviders. All errors and warnings are now piped to stderr over stdout.