Harden protection with pinned requests and path-param encoding#2486
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2486 +/- ##
==========================================
- Coverage 91.34% 90.91% -0.43%
==========================================
Files 248 275 +27
Lines 20709 24285 +3576
==========================================
+ Hits 18916 22079 +3163
- Misses 1793 2206 +413 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Replace all direct
requests.*()calls in agent tools and parsers withpinned_request()fromsafe_url.py, which resolves DNS once, validates all returned IPs against the SSRF blocklist, and dials the validated IP literal directly.Default
allow_redirects=Falseon all outbound requests, preventing redirect-based SSRF bypass (e.g.Location: http://169.254.169.254/...)URL-encode path parameter values with
quote(value, safe="")before template substitution, preventing path traversal and query injection via LLM-supplied argumentsWhy was this change needed? (You can also link to an open issue here)
Harden app protection.