feat(pty): close terminal tabs on process exit - #338
Merged
Conversation
lucas77778
requested changes
Jul 30, 2026
lucas77778
left a comment
lucas77778
left a comment
Member
There was a problem hiding this comment.
The PTY-exit/handoff path looks sound, but the Cmd+W path still conflicts with the native macOS Close Window accelerator. Please resolve that main-process/menu ownership conflict before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cmd+W/Ctrl+Wfor the focused terminal tab without closing the Electron windowVerification
devenv shell -- pnpm check:cidevenv shell -- pnpm testexit, forced PTY termination, andCmd+Win the real Electron appLinear: https://linear.app/arcbox/issue/CODE-349/featuipty-终端进程被杀后自动关闭对应-tab