Skip to content

fix(ci): use recursive glob for deb artifact paths#70

Merged
05F3759DF merged 1 commit intomainfrom
fix/ci-deb-artifact-paths
Mar 19, 2026
Merged

fix(ci): use recursive glob for deb artifact paths#70
05F3759DF merged 1 commit intomainfrom
fix/ci-deb-artifact-paths

Conversation

@05F3759DF
Copy link
Copy Markdown
Contributor

Summary

Fix CI workflow to properly find and upload Debian package artifacts.

Changes

  • Changed artifact path pattern from *.deb to **/*.deb to recursively match deb files in subdirectories (focal/, jammy/, noble/)
  • Added merge-multiple: true to download-artifact action
  • Made release job robust to missing artifacts with proper error handling

Testing

  • CI will validate the fix on this PR

Related

Fixes artifact upload warning: "No files were found with the provided path: packaging/deb/output/*.deb"

Deb files are placed in subdirectories (focal/, jammy/, noble/)
but the workflow was using non-recursive glob pattern.
Copy link
Copy Markdown

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot bot commented Mar 19, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 file)
  • .github/workflows/package.yml - CI workflow fix for artifact paths

Review Notes

This PR correctly addresses the artifact upload issue by:

  1. Path pattern fix (*.deb**/*.deb) - The recursive glob pattern will now properly match deb files in subdirectories like focal/, jammy/, noble/

  2. merge-multiple: true - Properly consolidates all downloaded artifacts into a single directory structure

  3. Defensive error handling - Added appropriate checks for missing artifacts and empty directories to prevent CI failures

The implementation is sound with no security vulnerabilities, runtime errors, or logic bugs detected.

@05F3759DF 05F3759DF merged commit 37253a5 into main Mar 19, 2026
24 checks passed
@05F3759DF 05F3759DF deleted the fix/ci-deb-artifact-paths branch March 19, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant