fix(packaging): update debian changelog version from CMakeLists.txt#71
Merged
fix(packaging): update debian changelog version from CMakeLists.txt#71
Conversation
Build scripts now dynamically update the version in debian/changelog from apps/axon_recorder/CMakeLists.txt instead of using hardcoded values.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Version is dynamically updated from CMakeLists.txt during build.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge (Already Merged) Files Reviewed (16 files)
Review NotesThe PR correctly:
The sed pattern |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Debian package version to sync with CMakeLists.txt instead of using hardcoded values in changelog files.
Problem
The build scripts were copying debian changelog files with hardcoded version
0.2.1-1but never updating them to match the actual project version (0.3.0) defined inapps/axon_recorder/CMakeLists.txt.Changes
Added version update step to all build scripts after copying debian files:
build-standalone.shbuild-ros1.shbuild-ros2.shbuild-udp.shbuild-plugin.shbuild-plugin-udp.shThe sed command updates the version in changelog format:
package (X.Y.Z-N)Testing
CI will build packages with correct version 0.3.0-1 after merge.