feat: Add schema selection to challenge creation dialog#197
Merged
Conversation
New Challenge button now opens a dialog where users can add schemas to request specific credentials. Selected schemas shown as removable chips. Empty schema list creates an open challenge as before. Also fixes verify response notification to use success (green) instead of error (red). Closes #129 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace issuer text field with a dropdown populated from agent list. Defaults to "Any issuer" when no specific issuer is required. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds schema/issuer selection to the “New Challenge” flow so challenges can optionally request specific credential presentations, and wires this UX into multiple front-ends.
Changes:
- Introduces a “New Challenge” dialog that lets users add one or more (schema, optional issuer) requirements and displays them as removable Chips.
- On creation, resolves selected schema/issuer aliases to DIDs via
lookupDIDand passes achallenge.credentialsspec tocreateChallenge. - Updates UI navigation (Chrome extension adds an Auth tab) and adjusts VALID response notification behavior in the Keymaster/Gatekeeper UIs.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| services/keymaster/client/src/KeymasterUI.js | Adds challenge-creation dialog w/ schema+issuer selection and passes credential spec into createChallenge; adjusts VALID notification. |
| services/gatekeeper/client/src/KeymasterUI.js | Mirrors Keymaster UI changes for challenge dialog/spec + VALID notification. |
| apps/react-wallet/src/components/AuthTab.tsx | Adds challenge dialog/spec-building via lookupDID + createChallenge; updates “New…” button UX. |
| apps/chrome-extension/src/components/BrowserContent.tsx | Adds an Auth tab entry and renders the Auth panel in the extension sidebar. |
| apps/chrome-extension/src/components/AuthTab.tsx | Adds challenge dialog/spec-building via lookupDID + createChallenge; updates “New…” button UX. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
…fications Close challenge dialog only after successful creation so users keep their selections on error. Use setSuccess/setError for verify response instead of setWarning in react-wallet and chrome-extension AuthTabs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lookupDIDon createCloses #129
Test plan
🤖 Generated with Claude Code