feat: move lightning payment filtering to client with full state display#237
Merged
feat: move lightning payment filtering to client with full state display#237
Conversation
Removes server-side filtering of payments to only 'success' status. All payments are now passed through with status (success/pending/failed) and expiry fields, and the client derives display state: settled, pending, failed, or expired (pending payments whose expiry timestamp has passed). Updates payments table in all four client apps with new column layout: Date, Amount (sats), Fee, Status, Memo — fixed widths via tableLayout. Closes #236 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds four checkboxes (settled, pending, failed, expired) next to the Refresh button to filter displayed payments by status in all four client apps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Moves Lightning payment state handling to the clients by returning all LNbits payments (not just status === 'success') and adding richer status/expiry fields so UIs can display settled / pending / failed / expired consistently across apps.
Changes:
- Removed server-side success-only filtering and exposed LNbits
status(andexpiry) with each payment record. - Extended the shared
LightningPaymentRecordtype and updated client UIs to compute a display status and add status filter checkboxes. - Refactored the payments tables across four clients to a consistent fixed-layout column design (Date / Amount / Fee / Status / Memo).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| services/drawbridge/server/src/lnbits.ts | Returns all LNbits payments and maps status/expiry through the API response. |
| packages/gatekeeper/src/types.ts | Extends LightningPaymentRecord with status and expiry fields (and clarifies amount sign). |
| apps/react-wallet/src/components/LightningTab.tsx | Adds status filters and a fixed-layout payments table with derived display status. |
| apps/browser-extension/src/components/LightningTab.tsx | Mirrors react-wallet Lightning payments UI updates for consistent display/status filtering. |
| apps/gatekeeper-client/src/KeymasterUI.jsx | Updates payments tab table layout and client-side derived status + filters. |
| apps/keymaster-client/src/KeymasterUI.jsx | Updates payments tab table layout and client-side derived status + filters. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
status === 'success'filter inlnbits.ts— all payments passed through with full stateLightningPaymentRecordwithstatus: 'success' | 'pending' | 'failed'andexpiry?: stringtableLayout: fixedandcolgroupTest plan
Closes #236
🤖 Generated with Claude Code