Merged
Conversation
81b49be to
84a6404
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens LNbits startup when using the CLN REST wallet by blocking startup until CLN REST is reachable and authenticated, and by configuring Docker to restart LNbits so transient boot races can self-heal.
Changes:
- Require
CLNREST_READONLY_RUNEand perform an authenticated/v1/listfundsreadiness check before launching LNbits. - Fail startup (exit non-zero) instead of starting LNbits in a known-broken mode when CLN REST isn’t ready within the timeout.
- Add
restart: unless-stoppedto the LNbits service in the lightning compose stack.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/lnbits-entrypoint.sh | Adds authenticated CLN REST readiness gating and fails fast when CLN REST isn’t ready. |
| docker-compose.lightning.yml | Ensures LNbits is restarted automatically to recover from transient startup races. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification