Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a guided “curl | bash” onboarding flow for installing and configuring the Keymaster CLI, plus documentation updates describing how the installer works and how to persist required environment variables.
Changes:
- Added
scripts/install-keymaster.shinteractive installer (Node/npm detection, Keymaster install, prompts for ID/passphrase/Gatekeeper URL, runskeymaster create-id). - Documented the hosted installer command in the root README and the
@didcid/keymasterpackage README. - Added guidance about environment variable persistence when running via
curl | bash.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| scripts/install-keymaster.sh | New guided installer script for Keymaster onboarding and initial ID creation. |
| packages/keymaster/README.md | Documents the guided installer and explains the prompt/persistence behavior. |
| README.md | Adds a “Keymaster Onboarding” section pointing users to the hosted installer flow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #253