Add wallet handoff for app and extension#271
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Implements a canonical HTTPS wallet URL entrypoint that can hand off auth / credential accept / alias accept flows to the best available handler (browser extension on desktop, native app deep-link on mobile, otherwise web fallback).
Changes:
- React wallet: parse
?challenge=,?credential=,?alias=&did=and route via extension handoff (desktop) or app deep-link attempt (mobile) with web fallback. - React wallet: add alias deep-link parsing/dispatching so alias accepts work in web fallback.
- Browser extension: add a content-script bridge to receive wallet-site handoff requests and open the appropriate extension UI.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| docker-compose.yml | Removes react-wallet Vite service URLs from compose env configuration. |
| apps/react-wallet/src/main.tsx | Adds wallet URL parsing + extension probe/open handshake + mobile deep-link attempt + extension-handoff UI state. |
| apps/react-wallet/src/contexts/WalletProvider.tsx | Adds alias parsing from deep-link queue and dispatches archon:openAlias. |
| apps/react-wallet/src/contexts/UIContext.tsx | Handles archon:openAlias event by switching to aliases UI and pre-filling fields. |
| apps/browser-extension/src/contentScript/contentScript.ts | Adds window.postMessage probe/open handlers to relay wallet handoff requests to extension background. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a single-link wallet handoff flow for auth, credential accept, and alias accept.
The React wallet now treats the HTTPS wallet URL as the canonical entrypoint and chooses the best available handler:
archon://...Changes
challenge,credential, andalias + didactions to the extension when availableSupported URL shapes
?challenge=<did>?credential=<did>?alias=<name>&did=<did>Verification
npm run buildinapps/react-walletnpm run buildinapps/browser-extensionCloses #270.