Skip to content

feat: Add keymaster address CLI commands#378

Merged
macterra merged 8 commits intomainfrom
feat/keymaster-cli-addresses
Apr 5, 2026
Merged

feat: Add keymaster address CLI commands#378
macterra merged 8 commits intomainfrom
feat/keymaster-cli-addresses

Conversation

@macterra
Copy link
Copy Markdown
Collaborator

@macterra macterra commented Apr 4, 2026

Summary

  • add list-addresses, import-address, check-address, add-address, and remove-address to the package keymaster CLI
  • add keymaster address APIs backed by Herald name lookup and claim/delete flows
  • store address metadata under each wallet ID and cover the new behavior with focused tests

Why

  • starts issue Add addresses to wallet #275 from the CLI layer
  • gives keymaster first-class address management without duplicating DID ownership in wallet storage

Validation

  • npm test -- --runTestsByPath tests/keymaster/address.test.ts
  • npm run build:esm -w @didcid/keymaster

@macterra macterra changed the title [codex] Add keymaster address CLI commands feat: Add keymaster address CLI commands Apr 4, 2026
@macterra macterra requested a review from Copilot April 4, 2026 22:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds first-class “address” management to Keymaster (wallet storage + Herald/Drawbridge-backed lookup/claim/delete flows) and exposes it via new Keymaster CLI commands, with focused unit tests.

Changes:

  • Introduce address data types and extend KeymasterInterface with address methods.
  • Implement list/import/check/add/remove address flows in Keymaster and surface them in the CLI.
  • Add Jest coverage for the new address behaviors and document the new CLI commands.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/keymaster/address.test.ts New tests covering list/import/check/add/remove address behaviors and wallet persistence.
packages/keymaster/src/types.ts Adds address-related types and extends IDInfo + KeymasterInterface.
packages/keymaster/src/keymaster.ts Implements address normalization/parsing, registry lookup, and claim/delete flows plus wallet storage.
packages/keymaster/src/keymaster-client.ts Adds client methods for address endpoints on the remote Keymaster API.
packages/keymaster/src/cli.ts Adds list-addresses, import-address, check-address, add-address, remove-address commands.
packages/keymaster/README.md Documents the new CLI commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/keymaster/src/keymaster-client.ts
Comment thread packages/keymaster/src/keymaster.ts
Comment thread packages/keymaster/src/keymaster.ts Outdated
@macterra macterra marked this pull request as ready for review April 5, 2026 00:39
@macterra macterra merged commit 35dc407 into main Apr 5, 2026
39 of 40 checks passed
@macterra macterra deleted the feat/keymaster-cli-addresses branch April 5, 2026 00:40
@macterra macterra mentioned this pull request Apr 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants