feat: Add keymaster address CLI commands#378
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class “address” management to Keymaster (wallet storage + Herald/Drawbridge-backed lookup/claim/delete flows) and exposes it via new Keymaster CLI commands, with focused unit tests.
Changes:
- Introduce address data types and extend
KeymasterInterfacewith address methods. - Implement
list/import/check/add/removeaddress flows inKeymasterand surface them in the CLI. - Add Jest coverage for the new address behaviors and document the new CLI commands.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/keymaster/address.test.ts | New tests covering list/import/check/add/remove address behaviors and wallet persistence. |
| packages/keymaster/src/types.ts | Adds address-related types and extends IDInfo + KeymasterInterface. |
| packages/keymaster/src/keymaster.ts | Implements address normalization/parsing, registry lookup, and claim/delete flows plus wallet storage. |
| packages/keymaster/src/keymaster-client.ts | Adds client methods for address endpoints on the remote Keymaster API. |
| packages/keymaster/src/cli.ts | Adds list-addresses, import-address, check-address, add-address, remove-address commands. |
| packages/keymaster/README.md | Documents the new CLI commands. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list-addresses,import-address,check-address,add-address, andremove-addressto the package keymaster CLIWhy
Validation
npm test -- --runTestsByPath tests/keymaster/address.test.tsnpm run build:esm -w @didcid/keymaster