Merged
Conversation
macterra
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a dedicated Identity “Name” sub-tab to multiple client UIs so users can view, set, and remove the selected identity’s name property without using generic property editing.
Changes:
- Introduces a new
Nameidentity sub-tab and associated UI fields/actions (set/remove). - Adds client-side loading/error state and fetch logic for reading the current
namevalue via DID resolution. - Updates identity tab navigation to include the new
nametab.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/react-wallet/src/components/IdentitiesTab.tsx | Adds “Name” identity tab UI + load/set/remove logic for the name property. |
| apps/browser-extension/src/components/IdentitiesTab.tsx | Mirrors the react-wallet change: “Name” tab with load/set/remove for name. |
| apps/gatekeeper-client/src/KeymasterUI.jsx | Adds “Name” identity sub-tab to KeymasterUI with load/set/remove for name. |
| apps/keymaster-client/src/KeymasterUI.jsx | Same “Name” identity sub-tab + logic as gatekeeper-client’s KeymasterUI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Namesub-tab underIdentitiesingatekeeper-client,keymaster-client,react-wallet, and the browser extensionnameproperty for the selected identitynameproperty directly from the identity UIWhy
Avatar management now has a dedicated identity tab, and the
nameproperty needs the same kind of direct UI support instead of requiring generic property editing.Impact
Users can manage the current identity's
nameproperty from a focused identity-specific tab across all four wallet clients, without the extra DID-resolution request that review flagged.Validation
npm run buildinapps/gatekeeper-clientnpm run buildinapps/keymaster-clientnpm run buildinapps/react-walletnpm run buildinapps/browser-extension(passes with existing webpack bundle-size warnings)