feat: Add address publish actions across clients#392
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds per-address Publish/Unpublish controls across the various clients’ identity address UIs, persisting the “published” address into the identity’s didDocumentData.address field (via mergeData) and keeping the UI state synchronized across refresh/startup/removal flows.
Changes:
- Add Publish/Unpublish actions to address lists (React wallet, browser extension, Gatekeeper client, Keymaster client) and visually highlight the published address.
- Sync published-address state by reading
didDocumentData.addresson refresh/resolve, and clear it when the published address is removed. - Document that
apps/gatekeeper-client/src/KeymasterUI.jsxandapps/keymaster-client/src/KeymasterUI.jsxmust remain identical.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/react-wallet/src/components/IdentitiesTab.tsx | Adds published-address state, publish/unpublish actions, and UI updates in the Addresses table. |
| apps/browser-extension/src/components/IdentitiesTab.tsx | Mirrors the React wallet changes for publish/unpublish actions and published state syncing. |
| apps/keymaster-client/src/KeymasterUI.jsx | Adds publish/unpublish controls in the identity addresses table and syncs published state during DID resolution. |
| apps/gatekeeper-client/src/KeymasterUI.jsx | Keeps parity with keymaster-client KeymasterUI changes (publish/unpublish + syncing). |
| AGENTS.md | Adds repo guidance to keep the two KeymasterUI.jsx copies identical. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addressproperty and ensure only one address is published at a timeKeymasterUI.jsxcopies must stay identicalTesting