fix: copy Cargo.lock into Rust gatekeeper Docker build#412
Merged
Conversation
The cid crate's transitive dependency core2 v0.4.0 was yanked from crates.io. Cargo can still use yanked versions when they appear in a lockfile, but the Dockerfile only copied Cargo.toml, so every build resolved from scratch and hit the yank. Copy Cargo.lock alongside Cargo.toml so the builder uses pinned, known-good versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cidcrate's transitive dependencycore2 v0.4.0was yanked from crates.io. Cargo can still use yanked versions when they appear in a lockfile, but the Dockerfile only copiedCargo.toml, so every build resolved dependencies from scratch and hit the yank.This copies
Cargo.lockalongsideCargo.tomlso the builder uses pinned, known-good versions.Fixes the failing Build & Test Docker images (rust gatekeeper) CI check.