Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the Satoshi mediator’s startup block-sync logic so it correctly backfills the full configured block range (from config.startBlock) instead of assuming that reaching the chain tip implies historical coverage in Gatekeeper.
Changes:
- Resume sync from
latest.height + 1when a complete backfill is detected (avoid re-adding the latest stored block). - Skip startup sync when
config.startBlockis ahead of the current chain tip, and detect partial backfills by verifying the configured start block exists in Gatekeeper. - Add a helper to report sync progress as a percentage of the configured range (
startBlock..tip) and use it in both sync paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix satoshi mediator startup sync so it does not treat the latest stored block height as proof that the full configured range has been backfilled.
What changed
latest.height + 1instead of re-adding the latest known blockWhy
Gatekeeper can contain a recent tail of BTC mainnet blocks without having the full range from the configured start block. In that case the old logic would see the latest stored height at tip and incorrectly skip the missing historical backfill.