Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves DTG credential support by renaming the schema property from $credentialTypes to $credentialType, adding support for custom credential contexts via $credentialContext, changing credential type behavior from merge to override, and introducing a new updateDID API method.
Changes:
- Renamed
$credentialTypesto$credentialTypefor schema definitions with override semantics instead of merge - Added
$credentialContextsupport to allow schemas to specify custom credential contexts - Implemented
updateDIDmethod across the stack (core, client, API, and tests)
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/keymaster/credential.test.ts | Updated tests to reflect new property name and override behavior for credential types |
| tests/keymaster/client.test.ts | Added comprehensive tests for the new updateDID method including error handling |
| services/keymaster/server/src/keymaster-api.ts | Added PUT endpoint for updating DID documents with swagger documentation |
| services/keymaster/client/src/KeymasterUI.js | Updated to use $credentialType property for schema name extraction |
| services/gatekeeper/client/src/KeymasterUI.js | Updated to use $credentialType property for schema name extraction |
| packages/keymaster/src/types.ts | Added updateDID method to KeymasterInterface |
| packages/keymaster/src/keymaster.ts | Implemented credential context override, credential type override, and improved empty claims handling |
| packages/keymaster/src/keymaster-client.ts | Added client method for updateDID with proper error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macterra
force-pushed
the
47-transition-schemas
branch
from
e3562e7 to
6f0f33b
Compare
Pull Request Test Coverage Report for Build 21681256633Details
💛 - Coveralls |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.