This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Parse gitignore file Fix#228
Merged
fleveillee merged 4 commits intoupdate-importmap-processorfrom Nov 2, 2023
Merged
Conversation
montalvomiguelo
force-pushed
the
parse-gitignore-fix
branch
from
3fc12cd to
09cad44
Compare
Contributor
|
Missing patch version bump and changelog.md update |
Contributor
|
Your PR description says you’re fixing an error, however, the changelog indicates that this is a change. You should use fixed instead. Feel free to explain that your “fix” is due to a package dependency update, but it is still a fix. A functionality change is required to use the Changed category. Atop of the CHANGELOG.md file, you can find a reference to this page: https://keepachangelog.com/en/1.1.0/ which I invite you to read when you have a chance. |
montalvomiguelo
added a commit
that referenced
this pull request
Nov 3, 2023
* Refactor Import map processor and add comments * Parse gitignore file Fix (#228) * Parse gitignore file Fix * Remove reference to components * Replace right hand instance of * * Clean up * Clean up --------- Co-authored-by: Frédéric Léveillée <fleveillee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new version of parse-gitignore does not return an array of patterns out-of-the-box anymore, which causes the following error during watch mode.
This PR adjusts the usage of the new version of the library per the examples in their code base
https://github.com/jonschlinkert/parse-gitignore/blob/caa44f75d7a66c80ea79fbc025a2a402d41ad1f4/examples/parse-file.js#L7