This repository was archived by the owner on Mar 4, 2025. It is now read-only.
Shopify CLI Plugin Integration#272
Merged
montalvomiguelo merged 3 commits intomainfrom Dec 29, 2023
Merged
Conversation
montalvomiguelo
force-pushed
the
plugin
branch
3 times, most recently
from
bec16a1 to
3d62192
Compare
Contributor
|
Nice! Understood. I'm good with this approach. Couple points:
|
Contributor
Author
|
Yup, we can do that, just wanted to get something working here. |
montalvomiguelo
force-pushed
the
plugin
branch
7 times, most recently
from
f17d1a6 to
a6d06fb
Compare
Contributor
Author
|
@t-kelly I studied more Oclif, and I was able to make our plugin work within the current project setup. We have an ESM plugin that does not need a separate workspace and does not need any build steps/TypeScript 🎉 |
montalvomiguelo
force-pushed
the
plugin
branch
6 times, most recently
from
291232c to
36a5ee3
Compare
Refactor plugin using vanilla JS Undo workspaces Clean up Linter errors fix Clean up Update oclif config Update lock file Update run file Clean up Update packge.json file Update bin files Update commands
Update readme file Update readme file
montalvomiguelo
force-pushed
the
plugin
branch
from
36a5ee3 to
5c9c513
Compare
fleveillee
reviewed
Jan 2, 2024
| const { args } = await this.parse(Install) | ||
|
|
||
| const command = 'npm' | ||
| // TODO: update archie so it can install a single component |
Contributor
There was a problem hiding this comment.
Archie already has that feature, but it is based on the theme's package.json archie config. We could port this feature to be command-line compatible.
fleveillee
reviewed
Jan 2, 2024
| }, | ||
| "engines": { | ||
| "node": ">=18.14.2" | ||
| "node": ">=18.12.0" |
Contributor
There was a problem hiding this comment.
I have no objections to that change; I'm just wondering why. Is it to be aligned to the shopify CLI?
Contributor
Author
There was a problem hiding this comment.
Yup it's the same version the Shopify CLI has
fleveillee
reviewed
Jan 2, 2024
| * [`shopify theme component dev [COMPONENT]`](#shopify-theme-component-dev-component) | ||
| * [`shopify theme component generate COMPONENT`](#shopify-theme-component-generate-component) | ||
| * [`shopify theme component install`](#shopify-theme-component-install) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary files to create a Shopify CLI plugin for archie.
"type": "module"and it's a CJS plugin. @oclif/core v3 does support ESM plugins, but the Shopify CLI uses @oclif/core v2 and cannot handle ESM plugins.archie remains as an ESM package but its package.json is marked as private.
Currently, the only way to interact with archie is through its command. The plugin consumes those functionalities as-is. This could be improved in future iterations. E.g. import {build} from 'archie'; build({options});