fix: correct Windows drive letter casing and platform error message#91
Merged
Merged
Conversation
- install.ps1: lowercase drive letter in POSIX path conversion (C: → /c, not /C) - install.sh: include Windows in supported platforms error message
Deploying archgate-cli with
|
| Latest commit: |
ecf5cf6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e99d108.archgate-cli.pages.dev |
| Branch Preview URL: | https://fix-install-script-windows-i.archgate-cli.pages.dev |
- install.ps1: lowercase drive letter in POSIX path conversion (C: → /c) - install.sh: include Windows in supported platforms error message - smoke-test.yml: pass GH_TOKEN so gh can query releases
$InstallDirPosix: was parsed as a drive-qualified variable.
Use ${InstallDirPosix} to delimit the variable name.
CI runners report /dev/tty as readable (-r) but fail to open it. Test with an actual fd open instead, and suppress stderr on the read to avoid noisy error messages in non-interactive environments.
The -replace script block syntax requires PowerShell 6+ and the $args automatic variable behaves differently across versions. Use -match with $Matches instead for cross-version compatibility.
exec redirect failures are fatal in sh and cannot be caught by if. Use a subshell (exec </dev/tty) so the failure is contained.
Merged
rhuanbarreto
added a commit
that referenced
this pull request
Mar 20, 2026
) * fix: correct Windows drive letter casing and platform error message - install.ps1: lowercase drive letter in POSIX path conversion (C: → /c, not /C) - install.sh: include Windows in supported platforms error message * fix: install script Windows fixes and CI smoke test auth - install.ps1: lowercase drive letter in POSIX path conversion (C: → /c) - install.sh: include Windows in supported platforms error message - smoke-test.yml: pass GH_TOKEN so gh can query releases * fix: delimit PowerShell variable to avoid parser error $InstallDirPosix: was parsed as a drive-qualified variable. Use ${InstallDirPosix} to delimit the variable name. * fix: detect missing TTY by actually opening /dev/tty CI runners report /dev/tty as readable (-r) but fail to open it. Test with an actual fd open instead, and suppress stderr on the read to avoid noisy error messages in non-interactive environments. * fix: use compatible PowerShell syntax for drive letter lowercasing The -replace script block syntax requires PowerShell 6+ and the $args automatic variable behaves differently across versions. Use -match with $Matches instead for cross-version compatibility. * fix: test /dev/tty in a subshell to avoid aborting the script exec redirect failures are fatal in sh and cannot be caught by if. Use a subshell (exec </dev/tty) so the failure is contained.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C:→/cinstead of/C), matching Git Bash conventionsTest plan
install.ps1on Windows and verify the Git Bash PATH entry uses a lowercase drive letter (e.g.,/c/Users/...)install.shand confirm the message mentions Windows