This repository was archived by the owner on Feb 19, 2020. It is now read-only.
Add --directory override to specify top level git directory. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the coverage reporter invokes git to determine the base directory of the git repository. If CI is being run inside a docker container, best practices include not copying the VCS information into the container to reduce the size. However, if that advice is followed, the coverage reporter is then unable to invoke git successfully for this use case. To support running without git, this adds a command line flag to manually specify the base directory without invoking git. This has the side benefit of allowing the coverage reporter to be useful for other VCS systems as well.
|
LGTM 👍 |
|
Looks good to me as well. |
|
@jkrukoff we're having some issues regarding the publish process of this new version in our build server to PyPi, will let you know when the version with your PR goes live =) |
Author
|
Thanks, looking forward to removing some hackery from my Dockerfile! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the coverage reporter invokes git to determine the base
directory of the git repository. If CI is being run inside a docker
container, best practices include not copying the VCS information into
the container to reduce the size. However, if that advice is followed,
the coverage reporter is then unable to invoke git successfully for this
use case.
To support running without git, this adds a command line flag to
manually specify the base directory without invoking git. This has the
side benefit of allowing the coverage reporter to be useful for other
VCS systems as well.