Skip to content

Fix broken localization in U2F, LUKS, and gfx driver preview#4500

Merged
svartkanin merged 1 commit intoarchlinux:masterfrom
Softer:fix-tr-code-issues
Apr 29, 2026
Merged

Fix broken localization in U2F, LUKS, and gfx driver preview#4500
svartkanin merged 1 commit intoarchlinux:masterfrom
Softer:fix-tr-code-issues

Conversation

@Softer
Copy link
Copy Markdown
Contributor

@Softer Softer commented Apr 29, 2026

Several places where strings that should be localized never reached translators.

  • authentication_handler.py:84 and encryption_menu.py:378 wrapped f-strings in tr(). The f-string evaluates before tr() runs, so xgettext extracts the literal placeholder syntax as the msgid while runtime passes the already-formatted string - the two never match. Switched both to tr('...{}').format(...), matching the pattern already used on line 95 of the same authentication file.
  • profile_menu.py:116 had a hardcoded Driver: label in the gfx driver hover preview. Wrapped with the existing Graphics driver msgid - already translated in every locale and used in the same context in global_menu.py:524.

base.pot updated to expose the two new placeholder-based msgids.

@Softer Softer requested a review from Torxed as a code owner April 29, 2026 14:08
@svartkanin svartkanin merged commit 3b026cb into archlinux:master Apr 29, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants