Update installer.py (#1)#793
Merged
Torxed merged 1 commit intoarchlinux:masterfrom Jan 26, 2022
OneLongneck:master
Merged
Conversation
Added "--removable" after "--bootloader-id=GRUB" on Line 669, because it would throw an input/output error without it on my laptop
Member
|
There's a warning on the arch wiki:
We've had similar issues on For instance, have you updated your bios firmware since purchase? Can we detect the need for this and only do it when necessary? |
Torxed
added a commit
that referenced
this pull request
Jan 26, 2022
Member
|
Me saying this is an understatement, bu you are awesome! All I had to do, was add this. So I'm merging this, and pulling it into |
Torxed
added a commit
that referenced
this pull request
Jan 26, 2022
Torxed
pushed a commit
that referenced
this pull request
Jan 26, 2022
12 tasks
Torxed
added a commit
that referenced
this pull request
Jan 26, 2022
* Added missing import * Brought back the mounting of subvolumes, or at least the beginning of it. Improved some logging and decreased the usage of try/except where unessecary (we can catch it higher up without catching and raising the same thing. * Trying to flatten the mount information to allow for sorted subvolume mounting. Still got issues. * Re-worked mountpoints logic to be a flat dictionary structure, where all subvolumes are mountpoint targets, but with relevant information. Had to work that into Partition().mount to support re-mounting a partition multiple times. That will have to be cleaned up. * Changed the default timeout to 15 as per the ISO * Corrected a path when creating loopdev name. * Added some debugging/warning * Fixed a path lookup issue * Added some debugging * Added more debugging * Removed excessive luks add_key() and crypttab() entries being generated by subvolumes. * Added more debugging * Avoiding excessive keyfile usage for partitions. Also added some debugging for BlockDevice. * Added more debugging * Added debugging and a hack to find /dev/sda from /dev/sda2 * Fixed ugly hack to use /dev/sdX instead of just sdX * Inconsistency in lsblk -no pkname made sorting a bit tricky, resorting to shortest string wins. * Tweak lookup * Tweak lookup * Added more debugging * Had to filter lsblk output because some entries are empty rows * Syntax issue * Added a comment clarifying the many steps of partition->blockdevice logic. * Added debug information * Added debug information * Added debug information * Fixed issue #908 * Added subvolume support for grub. Also added check to see if grub is installed before installing it (to avoid multiple calls to pacstrap even tho it doesn't hurt) * Modified 'sed' to use % as divider, since the replacement string can contain '/' * Added debugging * Testing GRUB with /boot/efi instead (might revert) * Reverted /boot/efi for GRUB. Did no difference. * Flake8 fix * Testing --removable from #793 if it solves the UEFI issue * Removing --remoable and pulling it from #793 for tracability * Update installer.py (#1) (#793) Added "--removable" after "--bootloader-id=GRUB" on Line 669, because it would throw an input/output error without it on my laptop * Remove debug information Co-authored-by: OneLongneck <95297344+OneLongneck@users.noreply.github.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added "--removable" after "--bootloader-id=GRUB" on Line 669, because it would throw:
"Could not prepare Boot variable:
Interrupted system call
grub-install: error efibootmgr failed to register the boot entry: Input/output error"
without it on my laptop (with every distro I tried installing)
🚨 PR Guidelines:
New features (v2.2.0)
All future work towards
v2.2.0is done againstmasternow.Any patch work to existing versions will have to create a new branch against the tagged versions.
Describe your PR
If the changes has been discussed in an Issue, please tag it so that we can backtrace from the issue later on.
If the PR is larger than ~20 lines, please describe it here unless described in an issue.
Testing
Any new feature or stability improvement should be tested if possible. Please follow the test instructions at the bottom of the README or use the ISO built on each PR.