Conversation
primary planes are sometimes rotated when the framebuffer console is rotated. While it is potentially useful to respect that, and rotate the app accordingly, it won't rotate the input of the app nor the cursor plane. Just use zero rotation everywhere. Provide feedback if a cursor vs. overlay plane was allocated, if prefer_cursor was set. We can only use fast cursor updates if a cursor plane was allocated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raspberry Pi 5 has so many planes now (56 to be exact) that the cursor planes simply didn't fit into the plane bitset.
Increase the size of the planes bitset to 128.
Also generally reduce logging for hardware cursor problems, and always use 0 rotation for planes to fix inconsistent plane rotations (for reasoning see commit)