Modernize Python code to 3.10+ idioms and add type hints#34
Merged
Conversation
- Add _SecondOrderNLTMMCython.pyi with full type stubs for all Cython extension classes: _Chi2Tensor, Material, _Wave, _Intensities, _SweepResultNonlinearTMM, _WaveSweepResultNonlinearTMM, _FieldsZ, _FieldsZX, _HomogeneousWave, _NonlinearLayer, NonlinearTMM, _SecondOrderNLIntensities, _SweepResultSecondOrderNLTMM, _WaveSweepResultSecondOrderNLTMM, and SecondOrderNLTMM - Add __init__.pyi re-exporting all public and private types - Add missing type annotations to 9 methods in _TmmForWavePackets.py - Add type hints to helper functions in test_TMM.py and test_SPDC.py - Add return type annotations to example script functions
336aeb9 to
e1f59e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
%string formatting with f-stringssuper()(Python 3+)class Foo:instead ofclass Foo(object):)os.pathwithpathlib.Pathtype() ==withisinstance()pylabwithmatplotlib.pyplotscipy.real/imagwithnp.real/np.imagfloat('inf')withmath.infnp.arangewithrange()for loop indexingExceptionif __name__ == '__main__': passblocks__all__toNonlinearTMM/__init__.pydocs/conf.py(remove encoding comment, updatemaster_doctoroot_doc)