chore: update npm dependencies#11
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/ardoco/traceviz/sessions/51118205-8e62-4d3d-bd8e-0769b52713a3 Co-authored-by: dfuchss <22198798+dfuchss@users.noreply.github.com>
… npm update Agent-Logs-Url: https://github.com/ardoco/traceviz/sessions/51118205-8e62-4d3d-bd8e-0769b52713a3 Co-authored-by: dfuchss <22198798+dfuchss@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
dfuchss
May 6, 2026 11:59
View session
…s tree-item selection When a tree item is selected VS Code applies list.activeSelectionIconForeground to ThemeIcon colours, making the circle-filled codicon appear black (light theme) or white (dark theme) instead of the configured visualisation colour. Replace the ThemeIcon with a vscode.Uri pointing to an inline SVG data-URI (same technique already used for gutter dots) so the hex colour is embedded in the image and is not overridden by selection styles. Add DecorationService.createCircleIconUri() as a reusable helper alongside the existing gutter-dot helpers. Agent-Logs-Url: https://github.com/ardoco/traceviz/sessions/89bcab2d-727f-4c83-b9df-894c893fb76a Co-authored-by: dfuchss <22198798+dfuchss@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Trace History tree item icon rendering to use an SVG data-URI so the active visualization color is preserved even when the item is selected, and refreshes the npm lockfile (including a bump to @vscode/test-cli).
Changes:
- Replace
ThemeIcon('circle-filled', ThemeColor)inHistoryItemwith an SVG data-URI icon generated viaDecorationService. - Add
DecorationService.createCircleIconUri(colorHex)helper to generate a single-circle SVG URI. - Update
@vscode/test-cli(and regeneratepackage-lock.json, pulling in various transitive updates).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/views/traceHistoryViewProvider.ts | Switch active history item icon to an SVG data-URI circle using embedded hex colors. |
| src/services/decoration.service.ts | Add helper to generate a single colored circle SVG URI for use in tree item icons. |
| package.json | Bump @vscode/test-cli version range. |
| package-lock.json | Lockfile refresh reflecting the dependency update and newer transitive resolutions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+122
to
+128
| const colorHex: Record<VizColor, string> = { | ||
| blue: CONSTANTS_COLOR_HEX_BLUE, | ||
| red: CONSTANTS_COLOR_HEX_RED, | ||
| orange: CONSTANTS_COLOR_HEX_ORANGE, | ||
| green: CONSTANTS_COLOR_HEX_GREEN | ||
| }; | ||
| this.iconPath = DecorationService.createCircleIconUri(colorHex[this.color]); |
Comment on lines
+56
to
+59
| static createCircleIconUri(colorHex: string): vscode.Uri { | ||
| const svg = `<svg width="${CONSTANTS_NUMBER_SVG_WIDTH}" height="${CONSTANTS_NUMBER_SVG_HEIGHT}" viewBox="0 0 ${CONSTANTS_NUMBER_SVG_WIDTH} ${CONSTANTS_NUMBER_SVG_HEIGHT}" xmlns="${CONSTANTS_STRING_SVG_NAMESPACE}"><circle cx="${CONSTANTS_NUMBER_SVG_CIRCLE_CENTER_X}" cy="${CONSTANTS_NUMBER_SVG_CIRCLE_CENTER_Y}" r="${CONSTANTS_NUMBER_SVG_CIRCLE_RADIUS}" fill="${colorHex}" stroke="${colorHex}" stroke-width="${CONSTANTS_NUMBER_SVG_CIRCLE_STROKE_WIDTH}"/></svg>`; | ||
| return vscode.Uri.parse(CONSTANTS_STRING_SVG_DATA_URI_PREFIX + Buffer.from(svg).toString('base64')); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ThemeIcon('circle-filled', ThemeColor)inHistoryItemwith an SVG data-URI icon so the colour is embedded and not overridden by VS Code's selection foreground when the tree item is clickedDecorationService.createCircleIconUri(colorHex)helper (consistent with existing gutter-dot helpers)@types/node/vscodestubs), not regressions