f64 hyperbolic: drop regressing fast paths, keep asinh win#119
Merged
arduano merged 1 commit intofeat/f64-wave-1from Mar 22, 2026
Merged
f64 hyperbolic: drop regressing fast paths, keep asinh win#119arduano merged 1 commit intofeat/f64-wave-1from
arduano merged 1 commit intofeat/f64-wave-1from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sinh_u35,cosh_u35,tanh_u35to scalar-mapped implementations (map::unary_f64)acosh_u35andatanh_u35to scalar-mapped implementationsasinh_u35SIMD fast path (still a strong benchmark win)Why
On x86, the family-local f64 fast paths for
sinh/cosh/tanhandatanhwere clear regressions, andacoshwas still a mild regression. This change keeps only the worthwhile implementation (asinh) and routes the others through safer scalar mapping.Validation
cargo test --testscargo bench --bench simd_math -- 'simd_math/f64/(sinh_u35|cosh_u35|tanh_u35)'cargo bench --bench simd_math_remaining_baseline -- 'simd_math_baseline/f64/(asinh_u35|acosh_u35|atanh_u35)'