This repository was archived by the owner on Apr 17, 2023. It is now read-only.
Refactored upload API #76
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also renamed function `upload_arduino_target` to `set_target_upload_port`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works refactors the upload API by creating a target dedicated for uploading rather than executing a command whenever CMake is run. This is a somewhat standard behavior in common frameworks.
The new upload target is named after the source target and append flash to its end.
Besides, the
upload_arduino_targetfunction has been renamed toset_upload_target_portas it describes more clearly what does it do. It's important to note that the target is created inside this function.Closes #73