check if data fits writeBuffer before copy#431
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #431 +/- ##
==========================================
- Coverage 15.26% 15.25% -0.02%
==========================================
Files 29 29
Lines 3681 3684 +3
==========================================
Hits 562 562
- Misses 3119 3122 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 54ed253
Click for full report table
Click for full report CSV |
pillo79
requested changes
May 4, 2026
Contributor
pillo79
left a comment
There was a problem hiding this comment.
Good catch, but I think ATT_ECODE_INSUFF_RESOURCES is more appropriate here.
andreagilardoni
approved these changes
May 5, 2026
Contributor
andreagilardoni
left a comment
There was a problem hiding this comment.
writeBuffer is assumed to have a minimum size that is not described anywhere. The check here is important.
|
Memory usage change @ 1460e1a
Click for full report table
Click for full report CSV |
pillo79
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.