Added condition for if wire implementation lacks end() #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ a303c11
Click for full report table
Click for full report CSV |
Contributor
Author
|
@aentinger would you mind incrementing the minor version number so this fix and other fixes pending can be downloaded by PlatformIO properly? |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the end() function so only if the platform implementation of TwoWire supports using the
TwoWire->end()function, theTwoWire->end()function will be used. This was brought up since ESP32 framework doesn't have an end function to call.The Arduino docs do not specify an end function as a official TwoWire API call, rather if the implementation supports it a WIRE_HAS_END constant will be defined and set to 1.