Skip to content

Conversation

@pu239ppy
Copy link
Contributor

@pu239ppy pu239ppy commented Feb 23, 2022

Recently I attempted to subclass LSM6DS3Class in order to add additional functionality in my sketch, I discovered that many of the defines I expected to work such as register addresses and LSM6DS3_ADDRESS are defined in the LSM6DS3.cpp file and including Arduino_LSM6DS3.h will not be enough. A simple fix and also a good practice would be to move these defines in the to the LSM6DS3.h.

In addition in order to enable inheritance private methods are now declared as protected

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions
Copy link

Memory usage change @ d708571

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash
% examples/SimpleAccelerometer
RAM for global variables
% examples/SimpleGyroscope
flash
% examples/SimpleGyroscope
RAM for global variables
%
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0

@pu239ppy pu239ppy changed the title move constant defines to header Enable inheritance Feb 23, 2022
@github-actions
Copy link

Memory usage change @ 0bfb498

Board flash % RAM for global variables %
arduino:megaavr:uno2018 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
arduino:samd:nano_33_iot 0 - 0 0.0 - 0.0 0 - 0 0.0 - 0.0
Click for full report table
Board examples/SimpleAccelerometer
flash
% examples/SimpleAccelerometer
RAM for global variables
% examples/SimpleGyroscope
flash
% examples/SimpleGyroscope
RAM for global variables
%
arduino:megaavr:uno2018 0 0.0 0 0.0 0 0.0 0 0.0
arduino:samd:nano_33_iot 0 0.0 0 0.0 0 0.0 0 0.0
Click for full report CSV
Board,examples/SimpleAccelerometer<br>flash,%,examples/SimpleAccelerometer<br>RAM for global variables,%,examples/SimpleGyroscope<br>flash,%,examples/SimpleGyroscope<br>RAM for global variables,%
arduino:megaavr:uno2018,0,0.0,0,0.0,0,0.0,0,0.0
arduino:samd:nano_33_iot,0,0.0,0,0.0,0,0.0,0,0.0

@pu239ppy
Copy link
Contributor Author

👋 ping

@per1234 per1234 added the topic: code Related to content of the project itself label Feb 26, 2022
@facchinm
Copy link
Contributor

LGTM!

@facchinm facchinm merged commit 8774124 into arduino-libraries:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: code Related to content of the project itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants