Fix: Removing unnecessary virtual keyword. #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is simply no need to declare those functions virtual. They don't override anything (no base class) and its highly unlikely that they will be overriden by a future derived class. However, should the later thing happen you can still make those functions virtual if necessary.
|
Memory usage change @ 42b69a9
Click for full report table
Click for full report CSV |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is simply no need to declare those functions virtual. They don't override anything (no base class) and its highly unlikely that they will be overriden by a future derived class. However, should the later thing happen you can still make those functions virtual if necessary.