readTemperature now returns float. #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented float temperature reading. Now LSM6SOXClass::readTemperature reads in float reference.
Changes according to last commit. readTemperature is now float type.
|
|
|
Memory usage change @ 8b377d4
Click for full report table
Click for full report CSV |
per1234
added
type: enhancement
aentinger
suggested changes
Aug 8, 2022
Contributor
aentinger
left a comment
aentinger
left a comment
There was a problem hiding this comment.
Sorry, but this whole PR is a no-go.
You are changing an API on which others are already relying upon. Furthermore its done in the most complicated and invasive manner. This PR needs a complete rework with a separate function readTemperatureFloat, or I'll never approve it.
| return 0; | ||
| } | ||
|
|
||
| temp_raw += ((int16_t)temp_H & 0b0000000011111111); |
Contributor
There was a problem hiding this comment.
0x00FF is incredibly easier to read than 0b0000000011111111, please fix.
| static int const TEMPERATURE_OFFSET_DEG = 25; | ||
|
|
||
| temperature_deg = (static_cast<int>(temperature_raw) / TEMPERATURE_LSB_per_DEG) + TEMPERATURE_OFFSET_DEG; | ||
| float fs = 125.0; /* -40 to 85 */ |
Contributor
There was a problem hiding this comment.
The variable name fs does not feel like an improvement over TEMPERATURE_LSB_per_DEG. P
Contributor
|
Implemented via #19 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-written readTemperature according to the datasheet. It seems the 16 bit temperature ADC stores bits to two separate 8 bit spaces. Converting them to signed int and again to float with temperature range, -40 to 85, then adjusting with + 25.0 seems to be yielding a close enough temperature.