-
Notifications
You must be signed in to change notification settings - Fork 0
Added integration test based on various board combinations. #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cmaglie thanks for the integration tests and documentation!
I have to ask 2 minor modifications before I merge:
- Please move the test folder under extras/go or extras/integration. I'll probably move python code under extras/python
- Please revert the changes to client.h . Debug prints will be removed after reaching a stable implementation of upcoming features
Done
I'm using the debug prints to validate the tests and check that the sketch has the desired output. |
e13fbc7 to
b558f99
Compare
7c6a4a8 to
6ad2c94
Compare
Let's keep the PR draft for the moment |
|
Way to go @cmaglie ! Super handy test cases 👍 |
This is a draft of integration tests to validate the implementation of the RPC library.