Skip to content

Conversation

@cmaglie
Copy link
Contributor

@cmaglie cmaglie commented May 6, 2025

This is a draft of integration tests to validate the implementation of the RPC library.

@eigen-value eigen-value self-requested a review May 7, 2025 08:40
Copy link
Collaborator

@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cmaglie thanks for the integration tests and documentation!
I have to ask 2 minor modifications before I merge:

  • Please move the test folder under extras/go or extras/integration. I'll probably move python code under extras/python
  • Please revert the changes to client.h . Debug prints will be removed after reaching a stable implementation of upcoming features

@cmaglie
Copy link
Contributor Author

cmaglie commented May 7, 2025

  • Please move the test folder under extras/go or extras/integration. I'll probably move python code under extras/python

Done

  • Please revert the changes to client.h . Debug prints will be removed after reaching a stable implementation of upcoming features

I'm using the debug prints to validate the tests and check that the sketch has the desired output.
Can we make them optional in some way?
Otherwise, I can keep this PR open and rebase on master from time to time.

@per1234 per1234 added the type: enhancement Proposed improvement label May 8, 2025
@cmaglie cmaglie self-assigned this May 8, 2025
@cmaglie cmaglie force-pushed the tests branch 2 times, most recently from e13fbc7 to b558f99 Compare May 8, 2025 12:46
@cmaglie cmaglie added the topic: infrastructure Related to project infrastructure label May 8, 2025
@cmaglie cmaglie force-pushed the tests branch 2 times, most recently from 7c6a4a8 to 6ad2c94 Compare May 8, 2025 16:16
@cmaglie cmaglie changed the title Added integration test based on Arduino Zero Added integration test based on various board combinations. May 9, 2025
@eigen-value
Copy link
Collaborator

  • Please move the test folder under extras/go or extras/integration. I'll probably move python code under extras/python

Done

  • Please revert the changes to client.h . Debug prints will be removed after reaching a stable implementation of upcoming features

I'm using the debug prints to validate the tests and check that the sketch has the desired output. Can we make them optional in some way? Otherwise, I can keep this PR open and rebase on master from time to time.

Let's keep the PR draft for the moment

@eigen-value eigen-value marked this pull request as draft May 9, 2025 09:45
@eigen-value
Copy link
Collaborator

Way to go @cmaglie ! Super handy test cases 👍

@eigen-value eigen-value marked this pull request as ready for review May 27, 2025 15:14
@eigen-value eigen-value merged commit 43256e8 into main May 27, 2025
2 checks passed
@cmaglie cmaglie deleted the tests branch May 28, 2025 09:04
@eigen-value eigen-value restored the tests branch June 27, 2025 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants