Remove unused platforms action input from "Compile Examples" workflow
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the "flow style" YAML syntax was used for this mapping. That was inconsistent with the rest of the workflow code, which uses the "block style" that is the standard for all YAML code in Arduino projects. This type of random mixing of the two styles makes otherwise fairly intuitive YAML code difficult to understand and maintain for anyone without deep familiarity with the obscure details of this language. Worse, the syntax had a form that was not specification-compliant: https://yaml.org/spec/1.2.2/#823-block-nodes > Flow nodes must be indented by at least one more space than the parent block collection. Although some lenient parsers do happen to support the previous non-compliant form, such support is not guaranteed, and non-compliance will cause a failure when used with any strict parser.
The "arduino/compile-sketches" action provides a `platforms` input by which the platform dependencies to be installed may be specified. This input is useful for use cases such as: * a 3rd party platform dependency which requires a supplemental package index * a platform dependency from an alternative source (e.g., development version of a platform from a Git repo) * transitory platform dependencies * version pinning However, the input is not required in the case where the platform is available from the primary package index, since the action will derive the platform ID from the FQBN. The workflow was based on a workflow from another repository which did explicitly define platform dependencies, and so did require the use of the `platform` input. However, the platform dependencies data was removed from this workflow, so the `platform` input serves no purpose and its presence only makes the workflow more difficult to understand and maintain.
per1234
added
type: imperfection
cmaglie
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arduino/compile-sketches action provides a
platformsinput by which the platform dependencies to be installed may be specified.This input is useful for use cases such as:
However, the input is not required in the case where the platform is available from the primary package index, since the action will derive the platform ID from the FQBN.
The workflow was based on a workflow from another repository which does explicitly define platform dependencies, and so did require the use of the
platforminput. However, the platform dependencies data was removed from this workflow, so theplatforminput serves no purpose and its presence only makes the workflow more difficult to understand and maintain.