Skip to content

Conversation

@eigen-value
Copy link
Collaborator

This is kind of urgent, but it should sort things out

fix: global vars in .h cause multiple definition errors
fix: __loopHook causes multiple definition error

fix: __loopHook causes multiple definition error
@eigen-value eigen-value requested review from facchinm and gbr1 October 27, 2025 11:11
@eigen-value eigen-value linked an issue Oct 27, 2025 that may be closed by this pull request
@per1234 per1234 added the bug Something isn't working label Oct 27, 2025
Copy link

@leonardocavagnis leonardocavagnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I did some tests with multiple inclusions and they all passed.

@eigen-value eigen-value merged commit f572a1a into main Nov 5, 2025
1 check passed
@eigen-value eigen-value deleted the 24-move-constructor-to-cpp-file branch November 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move constructor to .cpp file

4 participants