Skip to content

mod: rem bridge unused class param #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eigen-value merged 1 commit into from
Dec 15, 2025
Merged

mod: rem bridge unused class param #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/bridge.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,6 @@ class BridgeClass {

bool started = false;

MsgPack::str_t router_ver;

public:

explicit BridgeClass(HardwareSerial& serial) {
Expand Down
4 changes: 2 additions & 2 deletions src/monitor.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class BridgeMonitor: public Stream {
RingBufferN<BufferSize> temp_buffer;
struct k_mutex monitor_mutex{};
bool _connected = false;
bool _compatibility_mode;
bool _compatibility_mode = true;

public:
explicit BridgeMonitor(BridgeClass& bridge): bridge(&bridge) {}
Expand Down Expand Up @@ -61,7 +61,7 @@ class BridgeMonitor: public Stream {
bool out = false;
_connected = bridge->call(MON_CONNECTED_METHOD).result(out) && out;
MsgPack::str_t ver;
_compatibility_mode = !bridge->call(GET_VERSION_METHOD).result(ver);
_compatibility_mode = !bridge->getRouterVersion(ver);
k_mutex_unlock(&monitor_mutex);
return out;
}
Expand Down