Skip to content

Fix regression re report-size-deltas after updating actions/upload-artifact. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Fix regression re report-size-deltas after updating actions/upload-artifact. #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/compile-examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,23 @@ jobs:
- name: ArduinoBLE
- name: Arduino_CMSIS-DSP
sketch-paths: examples/ScienceKit/Nano33BLESenseFirmware
artifact-name-suffix: arduino-mbed_nano-nano33ble-1
- fqbn: arduino:mbed_nano:nanorp2040connect
platforms: |
- name: arduino:mbed_nano
libraries: |
- name: Arduino_LSM6DSOX
- name: ArduinoBLE
sketch-paths: examples/ScienceKit/RP2040ConnectFirmware
artifact-name-suffix: arduino-mbed_nano-nanorp2040connect
- fqbn: arduino:samd:mkrwifi1010
platforms: |
- name: arduino:samd
libraries: |
- name: ArduinoBLE
- name: Adafruit LSM9DS1 Library
sketch-paths: examples/ScienceKit/PhysicsLabFirmware
artifact-name-suffix: arduino-samd-mkrwifi1010-1
- fqbn: arduino:mbed_nano:nano33ble
platforms: |
- name: arduino:mbed_nano
Expand All @@ -72,6 +75,7 @@ jobs:
- name: ArduinoBLE
- name: Arduino_CMSIS-DSP
sketch-paths: examples/ScienceKitR2/Nano33BLESenseFirmware
artifact-name-suffix: arduino-mbed_nano-nano33ble-2
- fqbn: arduino:samd:mkrwifi1010
platforms: |
- name: arduino:samd
Expand All @@ -82,6 +86,7 @@ jobs:
- name: INA2xx
- name: SerialFlash
sketch-paths: examples/ScienceKitR2/PhysicsLabFirmware
artifact-name-suffix: arduino-samd-mkrwifi1010-2

steps:
- name: Checkout repository
Expand All @@ -108,4 +113,4 @@ jobs:
with:
if-no-files-found: error
path: ${{ env.SKETCHES_REPORTS_PATH }}
name: ${{ env.SKETCHES_REPORTS_PATH }}
name: sketches-report-${{ matrix.board.artifact-name-suffix }}
4 changes: 2 additions & 2 deletions .github/workflows/report-size-deltas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ jobs:
- name: Comment size deltas reports to PRs
uses: arduino/report-size-deltas@v1
with:
# The name of the workflow artifact created by the sketch compilation workflow
sketches-reports-source: sketches-reports
# Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
sketches-reports-source: ^sketches-report-.+